Review Request 115016: Make KJob usable from QML

Alex Merry kde at randomguy3.me.uk
Wed Jan 15 12:46:35 UTC 2014


On 15/01/14 12:43, Kevin Krammer wrote:
> On Tuesday, 2014-01-14, 23:12:56, Aurélien Gâteau wrote:
>> A NOTIFY signal is optional. If defined, it should specify one existing
>> signal in that class that is emitted whenever the value of the property
>> changes. NOTIFY signals for MEMBER variables must take zero or one
>> parameter, which must be of the same type as the property. The parameter
>> will take the new value of the property.
>>
>> The fix is probably just a matter of introducing a "void
>> percentChanged(int)" signal, and emitting it wherever percent() is emitted.
> 
> No need, the percent property is not using the MEMBER option of the Q_PROPERY 
> macro, it is using the classic READ followed by getter function approach.

Ah, good catch; I'd previously misread that...

Alex



More information about the Kde-frameworks-devel mailing list