Review Request 114961: Improve dependency specifications

Michael Palimaka kensington at gentoo.org
Wed Jan 15 05:56:49 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114961/
-----------------------------------------------------------

(Updated Jan. 15, 2014, 5:56 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: solid


Description
-------

QtConcurrent and QtTest only appear to be required by autotests, so check for them there instead of requiring them unconditionally.


Diffs
-----

  CMakeLists.txt ded17c4234bb15b51d8f13979a756c7f2dff178b 
  autotests/CMakeLists.txt 293ab7516d7df6697cd907df847de8f8642f48ae 

Diff: https://git.reviewboard.kde.org/r/114961/diff/


Testing
-------

Builds without without tests without the two libraries installed, and still builds and passes tests with them installed.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140115/09303040/attachment.html>


More information about the Kde-frameworks-devel mailing list