Review Request 114962: Improve dependency specifications
Michael Palimaka
kensington at gentoo.org
Wed Jan 15 05:54:33 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114962/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 5:54 a.m.)
Review request for KDE Frameworks.
Changes
-------
Small change to diff so that Qt5Concurrent is still found for tests, needed since previous commit.
Repository: kconfig
Description
-------
QtTest and QtConcurrent are only required for autotests, so no need to find them unconditionally.
QtWidgets is not actually used - QtGui is instead.
Diffs (updated)
-----
CMakeLists.txt b794b4b35479525873c342e6a6aa6677b3f00513
autotests/CMakeLists.txt 18317ee83995802e36a077d9289f4bcd45744e73
src/gui/CMakeLists.txt e6ef7468a1e736d5d0c0e601e24f961270f2d0f2
Diff: https://git.reviewboard.kde.org/r/114962/diff/
Testing
-------
Builds and tests pass without QtWidgets installed. Builds without QtTest and QtConcurrent installed.
Thanks,
Michael Palimaka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140115/60f62ce6/attachment.html>
More information about the Kde-frameworks-devel
mailing list