Review Request 115016: Make KJob usable from QML

[Aurélien Gâteau]

> On Jan. 14, 2014, 9:20 p.m., Alex Merry wrote:
> > src/lib/jobs/kjob.h, line 92
> > <https://git.reviewboard.kde.org/r/115016/diff/1/?file=233991#file233991line92>
> >
> >     I don't think this will work; I'm fairly sure that notify signals must have zero or one arguments, and the one argument must be the same type as the property.  The notify signal in this class has a preceding KJob* argument.
> 
> Aleix Pol Gonzalez wrote:
>     Quoting the documentation:
>     "A NOTIFY signal is optional. If defined, it should specify one existing signal in that class that is emitted whenever the value of the property changes."
>     
>     Also I've been using this in a plasmoid I'm porting and it doesn't seem to cause problems.

Quoting the *Qt 5* documentation: (http://doc-snapshot.qt-project.org/qt5-stable/properties.html)

A NOTIFY signal is optional. If defined, it should specify one existing signal in that class that is emitted whenever the value of the property changes. NOTIFY signals for MEMBER variables must take zero or one parameter, which must be of the same type as the property. The parameter will take the new value of the property.

The fix is probably just a matter of introducing a "void percentChanged(int)" signal, and emitting it wherever percent() is emitted.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115016/#review47395
-----------------------------------------------------------


On Jan. 14, 2014, 9:16 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115016/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 9:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Add a couple of Q_PROPERTY and Q_SCRIPTABLE to KJob, so that it can be consumed elsewhere. The idea isn't to be able to implement KJobs, but to be able to keep track of them from QML and check if it succeeded.
> 
> 
> Diffs
> -----
> 
>   src/lib/jobs/kjob.h 24dbaec 
> 
> Diff: https://git.reviewboard.kde.org/r/115016/diff/
> 
> 
> Testing
> -------
> 
> Everything still builds, shouldn't be a big deal.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140114/c95d514b/attachment.html>