Review Request 115016: Make KJob usable from QML

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115016/#review47395
-----------------------------------------------------------



src/lib/jobs/kjob.h
<https://git.reviewboard.kde.org/r/115016/#comment33726>

    I don't think this will work; I'm fairly sure that notify signals must have zero or one arguments, and the one argument must be the same type as the property.  The notify signal in this class has a preceding KJob* argument.


- Alex Merry


On Jan. 14, 2014, 8:16 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115016/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 8:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Add a couple of Q_PROPERTY and Q_SCRIPTABLE to KJob, so that it can be consumed elsewhere. The idea isn't to be able to implement KJobs, but to be able to keep track of them from QML and check if it succeeded.
> 
> 
> Diffs
> -----
> 
>   src/lib/jobs/kjob.h 24dbaec 
> 
> Diff: https://git.reviewboard.kde.org/r/115016/diff/
> 
> 
> Testing
> -------
> 
> Everything still builds, shouldn't be a big deal.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140114/e587379b/attachment-0001.html>