Review Request 115005: Install forwarding headers for plain knewstuff3 headers

[Friedrich W. H. Kossebau]

> On Jan. 14, 2014, 3:30 p.m., David Faure wrote:
> > Ship It!

Thanks. To avoid misunderstandings, is that a "Ship it" for both RRs?
Or for now just this?

Both depend on each other, otherwise will break things :)
(so will have to commit quickly after each other)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115005/#review47371
-----------------------------------------------------------


On Jan. 13, 2014, 11:39 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115005/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 11:39 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Jeremy Whiting.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> To be seen combined with https://git.reviewboard.kde.org/r/114988/
> 
>     Installation prefix was changed from knewtuff3/ to kns3/
>     Also remove no longer needed CamelCase forwarding headers, because
>     they are installed again with the old prefix from the KNewStuff module
> 
> See also discussion http://lists.kde.org/?l=kde-frameworks-devel&m=138963692808275&w=2
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 241e0c6 
>   src/includes/CMakeLists.txt 8781a9a 
>   src/includes/KNS3/DownloadDialog dd7ef3a 
>   src/includes/KNS3/Entry cb98675 
>   src/includes/KNS3/KNewStuffAction 48936eb 
>   src/includes/KNS3/KNewStuffButton aa033e1 
>   src/knewstuff3/downloaddialog.h PRE-CREATION 
>   src/knewstuff3/downloadmanager.h PRE-CREATION 
>   src/knewstuff3/downloadwidget.h PRE-CREATION 
>   src/knewstuff3/entry.h PRE-CREATION 
>   src/knewstuff3/knewstuffaction.h PRE-CREATION 
>   src/knewstuff3/knewstuffbutton.h PRE-CREATION 
>   src/knewstuff3/uploaddialog.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115005/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140114/e184f5d3/attachment-0001.html>