Review Request 115010: kwallet-framework: remove KDE4Support from tests CMakeLists.txt

Alex Merry kde at randomguy3.me.uk
Tue Jan 14 15:38:38 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115010/#review47375
-----------------------------------------------------------



src/runtime/kwalletd/backend/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115010/#comment33723>

    Actually, looking at the code for the tests, I think you can delete all of this.



src/runtime/kwalletd/backend/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115010/#comment33724>

    ...and remove Qt5::Test from here.


- Alex Merry


On Jan. 14, 2014, 3:31 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115010/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 3:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet-framework
> 
> 
> Description
> -------
> 
> looks like some leftover, compiles ok without it.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/backend/tests/CMakeLists.txt 54ec000 
> 
> Diff: https://git.reviewboard.kde.org/r/115010/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140114/82ccb173/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list