Review Request 115013: kde4support: make it build with QT_USE_QSTRINGBUILDER
Alex Merry
kde at randomguy3.me.uk
Tue Jan 14 15:23:56 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115013/#review47369
-----------------------------------------------------------
Ship it!
Yeah, given kde4support is a transitional library, I think this fix is fine.
- Alex Merry
On Jan. 14, 2014, 3:06 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115013/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 3:06 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kde4support
>
>
> Description
> -------
>
> it's lazy patch, but considering that it's not a single option that is getting removed, I would say it's ok.
>
>
> Diffs
> -----
>
> CMakeLists.txt c471101
>
> Diff: https://git.reviewboard.kde.org/r/115013/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140114/5d577554/attachment.html>
More information about the Kde-frameworks-devel
mailing list