Review Request 115012: add QT_USE_QSTRINGBUILDER to compiler settings

Alex Merry kde at randomguy3.me.uk
Tue Jan 14 15:23:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115012/#review47368
-----------------------------------------------------------

Ship it!


Once the other ones have gone in, this should be fine.

- Alex Merry


On Jan. 14, 2014, 3:06 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115012/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 3:06 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> as far as I know the QT_USE_FAST_CONCATENATION was changed to QT_USE_QSTRINGBUILDER somewhere around Qt4.6. For me all the frameworks compile, except the kinit, which needs a little patch.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEFrameworkCompilerSettings.cmake c27af0c 
> 
> Diff: https://git.reviewboard.kde.org/r/115012/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140114/68aa56f6/attachment.html>


More information about the Kde-frameworks-devel mailing list