Review Request 114988: Fix PREFIX parameter to ecm_generate_headers to match namespace KNS3

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114988/
-----------------------------------------------------------

(Updated Jan. 13, 2014, 11:39 p.m.)


Review request for KDE Frameworks, Aleix Pol Gonzalez, David Faure, and Jeremy Whiting.


Changes
-------

Improvements as discussed.


Repository: knewstuff


Description (updated)
-------

To be seen combined with https://git.reviewboard.kde.org/r/115005/

Currently the KNewStuff CamelCase forwarding headers are installed in [...]/include/KF5/KNewStuff3/knewstuff3
Which seems wrong, at least does not follow the pattern seen with the other namespaced modules. And breaks all existing #includes if the build does not use KDE4Support with its variants of the CamelCase forwarding headers.

Attached patch changes the PREFIX parameter to ecm_generate_headers from knewstuff3 to KNS3, so that the prefix matches the namespace of the classes in the module.
This means also a change of the prefix for the normal headers, but as discussed in http://lists.kde.org/?l=kde-frameworks-devel&m=138963692808275&w=2 that is preferred over the old solution. According new backward kde4-style support is proposed in the RR linked above.

Patch also
* removes knewstuffbutton.h, now installed from kdesupport
* removes no longer needed utility include dir cmake code (this could be found also in a few other frameworks, so there will be follow-up patches)


Diffs (updated)
-----

  src/CMakeLists.txt 05cd500 
  src/knewstuffbutton.h 931a465 

Diff: https://git.reviewboard.kde.org/r/114988/diff/


Testing
-------

Applied and run make install: CamelCase includes are installed in [...]/include/KF5/KNewStuff3/KNS3 directory, code which #includes KNS3/* without KDE4Support builds.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140113/04a5f755/attachment.html>