Review Request 115004: use KDeclarative namespace for kdeclarative framework classes
David Edmundson
david at davidedmundson.co.uk
Mon Jan 13 23:10:23 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115004/#review47353
-----------------------------------------------------------
Ship it!
Looks good to me.
- David Edmundson
On Jan. 13, 2014, 8:02 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115004/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 8:02 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> KDeclarative has very generic class names, therefore a bad practiche for public symbols.
> this moves it under KDeclarative:: namespace as discussed in the sprint
>
>
> Diffs
> -----
>
> src/configpropertymap.h aeb41b5
> src/configpropertymap.cpp 73e21d8
> src/kdeclarative.h 84e8df4
> src/kdeclarative.cpp 8aed99c
> src/private/kdeclarative_p.h 91e83cc
> src/private/kiconprovider.cpp 27eb8d1
> src/private/kiconprovider_p.h 3773e0c
> src/private/kioaccessmanagerfactory.cpp ea73c45
> src/private/kioaccessmanagerfactory_p.h 7f7cc73
> src/private/qmlobject_p.h e5b32f8
> src/private/rootcontext.cpp 503b430
> src/private/rootcontext_p.h 805f7fa
> src/qmlobject.h 5028559
> src/qmlobject.cpp d00ff40
> tests/kdeclarativetest.cpp dd34d88
>
> Diff: https://git.reviewboard.kde.org/r/115004/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140113/a2790290/attachment.html>
More information about the Kde-frameworks-devel
mailing list