Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

Alex Merry kde at randomguy3.me.uk
Mon Jan 13 12:00:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114989/#review47309
-----------------------------------------------------------


kde5-config is not a thing.  kf5-config does, but is provided by kde4support, which other frameworks (other than khtml as a special case) cannot depend on.

What this should actually change to is
kcfg_compiler="kconfig_compiler"
(or just replace all instances of $kcfg_compiler in the file with kconfig_compiler) and require that PATH is set correctly.

You can't just do a search-and-replace of "kde4" with "kde5" in the repositories!

- Alex Merry


On Jan. 12, 2014, 8:08 p.m., Siddharth Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114989/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 8:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references
> 
> 
> Diffs
> -----
> 
>   src/doxygen-preprocess-kcfg.sh 567a248 
> 
> Diff: https://git.reviewboard.kde.org/r/114989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Siddharth Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140113/6df3e447/attachment.html>


More information about the Kde-frameworks-devel mailing list