Review Request 114962: Improve dependency specifications

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114962/#review47231
-----------------------------------------------------------

Ship it!


This should be using QT_REQUIRED_VERSION everywhere.  Actually, if you could change it in the other CMakeLists.txt files, that would be good.  Then it can be shipped.


autotests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/114962/#comment33659>

    Use QT_REQUIRED_VERSION



src/gui/CMakeLists.txt
<https://git.reviewboard.kde.org/r/114962/#comment33660>

    Use QT_REQUIRED_VERSION


- Alex Merry


On Jan. 11, 2014, 10:43 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114962/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2014, 10:43 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> QtTest and QtConcurrent are only required for autotests, so no need to find them unconditionally.
> QtWidgets is not actually used - QtGui is instead.
> 
> 
> Diffs
> -----
> 
>   src/gui/CMakeLists.txt e6ef7468a1e736d5d0c0e601e24f961270f2d0f2 
>   autotests/CMakeLists.txt e4790f691f5a9ae2989faef742c31615713e0027 
>   CMakeLists.txt b794b4b35479525873c342e6a6aa6677b3f00513 
> 
> Diff: https://git.reviewboard.kde.org/r/114962/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass without QtWidgets installed. Builds without QtTest and QtConcurrent installed.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140111/8556b70c/attachment.html>