Review Request 114960: Fix build without X

Martin Gräßlin mgraesslin at kde.org
Sat Jan 11 09:32:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114960/#review47183
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Gräßlin


On Jan. 11, 2014, 3:21 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114960/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2014, 3:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> X support is optional as per the root CMakeLists.txt, but build fails without it due to linking unconditionally.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 0116c26aeb5ffbe31e8a29fffa29bbcd44d548f4 
> 
> Diff: https://git.reviewboard.kde.org/r/114960/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass both with and without X.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140111/f9e104db/attachment.html>


More information about the Kde-frameworks-devel mailing list