Review Request 114934: Improve dependency specification

Commit Hook null at kde.org
Fri Jan 10 23:46:15 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114934/#review47179
-----------------------------------------------------------


This review has been submitted with commit 0781a2f6dff97337ab8e1b4bedd8cca29609c2f8 by Michael Palimaka to branch master.

- Commit Hook


On Jan. 10, 2014, 11:25 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114934/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 11:25 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: threadweaver
> 
> 
> Description
> -------
> 
> Only benchmarks and autotests require QtTest, so move the dependency check there instead of requiring it unconditionally.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4165a3b07a983ac5715cc847c91c45a8d1f10003 
>   autotests/CMakeLists.txt 367ae9957b8aceeffd4eb09cfd1322420c7e6bee 
>   benchmarks/CMakeLists.txt 1621cec28914745d10de689de13bcbdc8d8ec6dc 
> 
> Diff: https://git.reviewboard.kde.org/r/114934/diff/
> 
> 
> Testing
> -------
> 
> Framework builds without QtTest, and tests still pass with QtTest.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140110/cd72a597/attachment.html>


More information about the Kde-frameworks-devel mailing list