Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114937/#review47144
-----------------------------------------------------------


What made me suggest this task was that --version was missing :)
Please add a addVersionOption() :)


src/kconfig_compiler/kconfig_compiler.cpp
<https://git.reviewboard.kde.org/r/114937/#comment33591>

    this is main(), return 0 would be enough.



src/kconfig_compiler/kconfig_compiler.cpp
<https://git.reviewboard.kde.org/r/114937/#comment33593>

    hmm, or too many? Maybe check for < 2, or adjust the error ... or check both separately.
    
    Also, this should be cerr, for error messages, as the name indicates.



src/kconfig_compiler/kconfig_compiler.cpp
<https://git.reviewboard.kde.org/r/114937/#comment33592>

    return 1


- David Faure


On Jan. 10, 2014, 4:14 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114937/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 4:14 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> $summary
> 
> 
> Diffs
> -----
> 
>   src/kconfig_compiler/kconfig_compiler.cpp df17d4c 
> 
> Diff: https://git.reviewboard.kde.org/r/114937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140110/d4ea8c6f/attachment.html>