Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc
Alex Merry
kde at randomguy3.me.uk
Wed Jan 8 22:49:51 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114917/#review47089
-----------------------------------------------------------
I'll leave someone who knows this better (David Faure?) to say yes or no to this change.
docs/README.kiosk
<https://git.reviewboard.kde.org/r/114917/#comment33562>
Hmm... this all looks very out-of-date. We no longer have KStandardDirs (or, at least, KConfig does not use it).
src/core/kconfig.cpp
<https://git.reviewboard.kde.org/r/114917/#comment33563>
Missed one - kde4rc appears twice on this line.
- Alex Merry
On Jan. 8, 2014, 10:24 p.m., Siddharth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114917/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 10:24 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc
>
>
> Diffs
> -----
>
> docs/README.kiosk 4974ace
> src/core/kconfig.cpp 4f5553d
>
> Diff: https://git.reviewboard.kde.org/r/114917/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Siddharth Sharma
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140108/c7594343/attachment.html>
More information about the Kde-frameworks-devel
mailing list