Review Request 114895: Guard against null QX11Info::connection()

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114895/#review47047
-----------------------------------------------------------


This review has been submitted with commit 11775f9351b9fe944d522039400d0bb118fc4733 by David Edmundson to branch master.

- Commit Hook


On Jan. 7, 2014, 1:57 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114895/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 1:57 p.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Marco Martin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Guard against null QX11Info::connection()
> 
> This can fail if the application is currently shutting down,
> this is currently causing a crash on closing plasma with dialogs
> open.
> 
> 
> Diffs
> -----
> 
>   src/kwindoweffects_x11.cpp 72cbb71 
> 
> Diff: https://git.reviewboard.kde.org/r/114895/diff/
> 
> 
> Testing
> -------
> 
> Opened plasmoidviewer -a org.kde.example.widgetgallery expanded the applet, then closed plasmoidviewer
> It used to crash, now it doesn't.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140108/e86bb843/attachment.html>