Review Request 114903: Do not set CMP0022
Stephen Kelly
steveire at gmail.com
Tue Jan 7 22:57:53 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114903/#review47015
-----------------------------------------------------------
Ship it!
This didn't work at all because NO_POLICY_SCOPE is not used when finding it.
- Stephen Kelly
On Jan. 7, 2014, 8:57 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114903/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 8:57 p.m.)
>
>
> Review request for Build System, KDE Frameworks and Stephen Kelly.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Do not set CMP0022
>
> We do not want to suppress any warnings about LINK_INTERFACE_LIBRARIES
> vs INTERFACE_LINK_LIBRARIES; everything should be using the latter,
> since we depend on CMake 2.8.12 everywhere.
>
>
> Diffs
> -----
>
> kde-modules/KDECMakeSettings.cmake 63cc90117a0a0655fa6e1db0f054235bb6333f29
>
> Diff: https://git.reviewboard.kde.org/r/114903/diff/
>
>
> Testing
> -------
>
> CMake runs fine (in a clean build dir) on KCoreAddons, KActivities (which still triggers the warning, but I don't think includes this file anyway) and plasma-frameworks.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140107/c1364189/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list