Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake

[Alex Merry]

> On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote:
> > The motivation was that if somebody had set up carefully his install dirs for kdelibs, he simply wanted to point a following project to the same CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use the same locations as the installed kdelibs.
> > Somebody, or maybe several people, requested this back then, I don't remember right now where or who it was.
> >

OK, thanks for the info.  I reckon this doesn't make much sense any more, given we have multiple tier1 frameworks.  About the best we could do is maybe follow Qt's layout, but I suspect that isn't worth it (if Qt even gives us all the necessary information).


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114904/#review47008
-----------------------------------------------------------


On Jan. 7, 2014, 9:18 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114904/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 9:18 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
> 
> This appears to be a hangover from the KDE4 days, which would adjust
> certain paths to match the ones for kdelibs if you installed an
> application to the same prefix as kdelibs.  This was probably to make
> KStandardDirs work properly in unusual setups.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169 
> 
> Diff: https://git.reviewboard.kde.org/r/114904/diff/
> 
> 
> Testing
> -------
> 
> CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140107/92cedaa5/attachment.html>