Review Request 114898: Remove use of obsolete add_compiler_export_flags

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114898/
-----------------------------------------------------------

(Updated Jan. 7, 2014, 7:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, KDE Frameworks and Stephen Kelly.


Repository: extra-cmake-modules


Description
-------

Remove use of obsolete add_compiler_export_flags

Set CMAKE_CXX_VISIBILITY_PRESET and CMAKE_VISIBILITY_INLINES instead
(which sets the default for all targets).

Note that the removal of include(GenerateExportHeader) means that this
will have to be explicitly included in the CMakeLists.txt of the
frameworks (as they use generate_export_header).


Diffs
-----

  kde-modules/KDECompilerSettings.cmake 72824e166d03dcc2d089814dc121f08ba998974a 

Diff: https://git.reviewboard.kde.org/r/114898/diff/


Testing
-------

Threadweaver builds, once include(GenerateExportHeader) is added to its CMakeLists.txt, and properly passes -fvisibility=hidden -fvisibility-inlines-hidden to the library code (although not to the test code).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140107/555d5bb2/attachment.html>