Review Request 114898: Remove use of obsolete add_compiler_export_flags

[Alex Merry]

> On Jan. 7, 2014, 5:03 p.m., Stephen Kelly wrote:
> > Does test code need to be compiled with the flags?

I see no reason why it would.  It's only really useful for libraries and plugins, as far as I'm aware, which I suspect is why CMake doesn't set it for those targets (just checked that it does indeed set it for modules with kimageformats).

I'll need to add include(GenerateExportHeader) to all the frameworks before I push this change, though.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114898/#review46985
-----------------------------------------------------------


On Jan. 7, 2014, 5:01 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114898/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 5:01 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Remove use of obsolete add_compiler_export_flags
> 
> Set CMAKE_CXX_VISIBILITY_PRESET and CMAKE_VISIBILITY_INLINES instead
> (which sets the default for all targets).
> 
> Note that the removal of include(GenerateExportHeader) means that this
> will have to be explicitly included in the CMakeLists.txt of the
> frameworks (as they use generate_export_header).
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake 72824e166d03dcc2d089814dc121f08ba998974a 
> 
> Diff: https://git.reviewboard.kde.org/r/114898/diff/
> 
> 
> Testing
> -------
> 
> Threadweaver builds, once include(GenerateExportHeader) is added to its CMakeLists.txt, and properly passes -fvisibility=hidden -fvisibility-inlines-hidden to the library code (although not to the test code).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140107/321e869b/attachment.html>