Review Request 114895: Guard against null QX11Info::connection()
David Edmundson
david at davidedmundson.co.uk
Tue Jan 7 13:57:46 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114895/
-----------------------------------------------------------
Review request for KDE Frameworks, Martin Gräßlin and Marco Martin.
Repository: kwindowsystem
Description
-------
Guard against null QX11Info::connection()
This can fail if the application is currently shutting down,
this is currently causing a crash on closing plasma with dialogs
open.
Diffs
-----
src/kwindoweffects_x11.cpp 72cbb71
Diff: https://git.reviewboard.kde.org/r/114895/diff/
Testing
-------
Opened plasmoidviewer -a org.kde.example.widgetgallery expanded the applet, then closed plasmoidviewer
It used to crash, now it doesn't.
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140107/2a272b1a/attachment.html>
More information about the Kde-frameworks-devel
mailing list