Review Request 114726: Make sure ktoolbar_unittest does not depend on global icon settings
Alex Merry
kde at randomguy3.me.uk
Sun Jan 5 12:31:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114726/
-----------------------------------------------------------
(Updated Jan. 5, 2014, 12:31 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks.
Repository: kxmlgui
Description
-------
Make sure ktoolbar_unittest does not depend on global icon settings
ktoolbar_unittest should not be testing the default settings of
KIconTheme anyway.
NB: I am away until 2nd Jan, so if it gets a "ship it", feel free to commit it in my absence in order to get Jenkins green again.
Diffs
-----
autotests/ktoolbar_unittest.cpp 2ee490d35b517a8121aa0aeda0d6ebb4256caad0
Diff: https://git.reviewboard.kde.org/r/114726/diff/
Testing
-------
Tests pass on my local machine (but they did before as well).
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140105/ec9bcf50/attachment.html>
More information about the Kde-frameworks-devel
mailing list