Review Request 114727: Unconditionally skip ICU-dependent encoding tests in kcharsettest
Alex Merry
kde at randomguy3.me.uk
Thu Jan 2 20:39:22 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114727/
-----------------------------------------------------------
(Updated Jan. 2, 2014, 8:39 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks.
Repository: kcodecs
Description
-------
Unconditionally skip ICU-dependent encoding tests
Qt 5.2 and the current 5.3 dev branch have still not resolved the issue
of certain encodings only being available if Qt was compiled with ICU
support. Since we do not know when it will be fixed, always skip this
part of the test regardless of the Qt version. This can be resolved as
and when the issue is fixed in Qt.
NB: I am away until 2nd Jan, so if it gets a "ship it", feel free to commit it in my absence in order to get Jenkins green again.
Diffs
-----
autotests/kcharsetstest.cpp 98039249d4e44e43b6cada614a4352367ea57c05
Diff: https://git.reviewboard.kde.org/r/114727/diff/
Testing
-------
Still compiles, kcharsettest still runs.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140102/26b89181/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list