What are the plans with CamelCase includes?

Christoph Cullmann cullmann at absint.com
Thu Jan 2 10:58:29 UTC 2014


----- Ursprüngliche Mail -----
> > Hmm,
> > 
> > just a question for the case, that we have a namespace, like KTextEditor.
> > 
> > At the moment we install (e.g. for KTextEditor::View):
> > 
> > KTextEditor/View
> > 
> > and
> > 
> > ktexteditor/view.h
> > 
> > Will that change still make that possible?
> 
> Ah, good point. The answer is: yes, if we put both under the framework name.
> If the framework is called KTextEditor, then this would lead to
> 
> include/KF5/KTextEditor/KTextEditor/View
> include/KF5/KTextEditor/ktexteditor/view.h
> 
> The benefit of that is that when an app forgets to link to KTextEditor,
> [which adds include/KF5/KTextEditor to the include path] the includes won't
> work.
> With the current solution, they will still work, which is inconsistent with
> non-namespaced headers.
> 
> I already set things up this way for KIO, which has both namespaced and non-
> namespaced headers.
> include/KF5/KIOCore/KIO/ListJob
> include/KF5/KIOCore/kio/listjob.h
> 
> Note the difference between the framework name (KIOCore) and the namespace
> (KIO), so it looks like it makes more sense here than when writing
> KTextEditor/KTextEditor - but that's just because your framework name matches
> your namespace name :-)
> 
> What do you think?
Yeah, that sounds sane enough, even if in my case it would look duplicated ;)

But the benefit of not found headers if wrong link flags is really nice!

Greetings
Christoph

-- 
----------------------------- Dr.-Ing. Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann at AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234


More information about the Kde-frameworks-devel mailing list