Review Request 116124: Always compile static lib with -fPIC

Luigi Toscano luigi.toscano at tiscali.it
Thu Feb 27 22:46:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116124/#review51207
-----------------------------------------------------------

Ship it!


I've seen the discussion in kde-frameworks-devel, my knowledge in this area is not so much but you convinced me, and we have some time for going back in case of issues.

- Luigi Toscano


On Feb. 27, 2014, 3:21 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116124/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Always compile static lib with -fPIC
> 
> See
> http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012375.html
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 0329bd383415b4fa265c1edd7f0f7d384fd17395 
> 
> Diff: https://git.reviewboard.kde.org/r/116124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140227/4dd6f8e5/attachment.html>


More information about the Kde-frameworks-devel mailing list