Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

[David Faure]

> On Feb. 24, 2014, 9:22 p.m., Albert Astals Cid wrote:
> > src/khelpclient.cpp, line 35
> > <https://git.reviewboard.kde.org/r/115959/diff/2/?file=245608#file245608line35>
> >
> >     Just curious, who is doing this "call setApplicationName() with the name of the desktop file" thing? I know KApplication did it but we're now not recommending to use it. Or is this something every app developer has to do? Is it documented somewhere?

I implemented in Qt 5.0 that applicationName() now defaults to the name of the binary on disk. This takes care of 95% of the cases :-)

For the other cases, there's setApplicationName (as documented in the porting doc when porting away from kapp, among other things), or very soon it will also be done by KAboutData::setApplicationData(myAboutData) (there's a RR pending for it).


> On Feb. 24, 2014, 9:22 p.m., Albert Astals Cid wrote:
> > src/khelpclient.cpp, line 76
> > <https://git.reviewboard.kde.org/r/115959/diff/2/?file=245608#file245608line76>
> >
> >     url is always help:/ isn't it? Not sure i understand the comment

? Not sure I understand *your* comment :-)


    QUrl url;
    if (!docPath.isEmpty()) {
        url = QUrl(QLatin1String("help:/")).resolved(QUrl::fromUserInput(docPath));
    } else {
        url = QUrl(QString::fromLatin1("help:/%1/index.html").arg(appname));
    }

    if (!anchor.isEmpty()) {
        QUrlQuery query(url);
        query.addQueryItem(QString::fromLatin1("anchor"), anchor);
        url.setQuery(query);
    }

How is this "always help:/" ? There much stuff after that, in the path and possibly in the query.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115959/#review50765
-----------------------------------------------------------


On Feb. 23, 2014, 11 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115959/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2014, 11 a.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> 3 commits:
> 
> 
> Unittest: make errors readable
> 
> --
> 
> Resurrect KConfigDialog::setHelp (used to come from KDialog).
> 
> It controls the default behavior of showHelp(), which is implemented
> using KHelpClient.
> 
> REVIEW: 115959
> 
> --
> 
> Move KHelpClient down from kxmlgui, for use in KConfigDialog.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigdialog_unittest.cpp e5322c1782c2a68c15451777066e28a9b7afea23 
>   src/CMakeLists.txt 7da7fba0c15153d6dee381c2b8f282e9837eae36 
>   src/kconfigdialog.h b06efc588c772ed655d581a0e021d92af5e0e280 
>   src/kconfigdialog.cpp 8db48e23f614530cef11a23a182b50d905327405 
>   src/khelpclient.h PRE-CREATION 
>   src/khelpclient.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115959/diff/
> 
> 
> Testing
> -------
> 
> Compiled all of KF5.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140227/06c31fdf/attachment.html>