Review Request 115963: KSharedConfig: Fix interference from kdeplatformtheme into unittests

[David Faure]

> On Feb. 25, 2014, 3:55 p.m., Matthew John Dawson wrote:
> > src/core/ksharedconfig.cpp, line 70
> > <https://git.reviewboard.kde.org/r/115963/diff/1/?file=245616#file245616line70>
> >
> >     Can you also please clear GlobalSharedConfigList::mainConfig please?  It should be reset anyways if a config is opened, but I rather be safe then sorry.

Good point indeed. Wasn't needed in my test, but better safe than sorry.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115963/#review50606
-----------------------------------------------------------


On Feb. 23, 2014, 11:54 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115963/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2014, 11:54 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew John Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Fix interference from kdeplatformtheme into unittests
> 
> kdeplatformtheme would load kdeglobals and the app config file, in order
> to load settings, before the unittests get a chance to call
> QStandardPaths::setTestModeEnabled(true). As a result, the test would
> keep getting references to "wrong" shared config objects, pointing to
> the real user's locations rather than the test directories.
> 
> This fixes e.g. kconfigdialog_unittest from kconfigwidgets for me
> (it only passes on build.kde.org because it doesn't install frameworkintegration
> for testing this framework)
> 
> 
> Diffs
> -----
> 
>   src/core/ksharedconfig.cpp 4f0e8d698f60fd05c25e4796be12a35facb8cd38 
> 
> Diff: https://git.reviewboard.kde.org/r/115963/diff/
> 
> 
> Testing
> -------
> 
> kconfigdialog_unittest now passes with frameworkintegration installed.
> 
> The tests in frameworkintegration still pass.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140227/b35d8c86/attachment-0001.html>