Review Request 115953: Clean up kdesu CMake files

Commit Hook null at kde.org
Thu Feb 27 13:04:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115953/#review51045
-----------------------------------------------------------


This review has been submitted with commit d5dc6cd3b45bdd5f13316a7689d2f3caed5d0050 by Alex Merry to branch master.

- Commit Hook


On Feb. 22, 2014, 5:43 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115953/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 5:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> -------
> 
> Remove KF5Service dependency from config file
> 
> KF5Service is a PRIVATE link, and so should not be a dependency in the
> config file.
> 
> Remove leftover code from kdelibs from CMakeLists.txt
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 15b01a0745206cbc761fd3572393ec56753ff2b6 
>   KF5SuConfig.cmake.in 9c2f96e3712490c56fd697b862c5d6a39755402d 
> 
> Diff: https://git.reviewboard.kde.org/r/115953/diff/
> 
> 
> Testing
> -------
> 
> Configures, compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140227/9066ed47/attachment.html>


More information about the Kde-frameworks-devel mailing list