Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/#review51043
-----------------------------------------------------------


While this fix would certainly work, I think it would be good to file a bug on CMake bug tracker for that issue (and add the bug id as a comment there). Maybe also ping Stephen Kelly about it, since he wrote the code in CMake which makes it possible to define a command to run before moc.

- Aurélien Gâteau


On Feb. 20, 2014, 5:58 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115918/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 5:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Fix kservice_desktop_to_json for Visual Studio
> 
> The CMake generator for Visual Studio cannot handle the new build-time
> kservice_desktop_to_json macro -> fall back to configure-time generation
> 
> 
> Diffs
> -----
> 
>   KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 
> 
> Diff: https://git.reviewboard.kde.org/r/115918/diff/
> 
> 
> Testing
> -------
> 
> ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140227/41ce9a8e/attachment-0001.html>