Review Request 116088: Remove FindDBusMenuQt5.cmake

Aurélien Gâteau agateau at kde.org
Thu Feb 27 12:19:06 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116088/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 1:19 p.m.)


Review request for KDE Frameworks.


Changes
-------

Also remove the addition of the local cmake/ dir to CMAKE_MODULE_PATH


Repository: knotifications


Description
-------

Remove FindDBusMenuQt5.cmake

dbusmenu-qt ships a CMake config file so we don't need a Find* file anymore.
Unfortunately the target defined does not set the include dir so for the
time being it is still necessary to call include_directories()
(might look into this if I find time)


Diffs (updated)
-----

  CMakeLists.txt ef84eb6 
  cmake/FindDBusMenuQt5.cmake 7d43489 
  src/CMakeLists.txt 900cb38 

Diff: https://git.reviewboard.kde.org/r/116088/diff/


Testing
-------

Builds, manual tests run as expected.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140227/90b8d93c/attachment.html>


More information about the Kde-frameworks-devel mailing list