Review Request 116062: Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches

David Gil Oliva davidgiloliva at gmail.com
Wed Feb 26 21:09:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116062/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 9:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcompletion


Description
-------

Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches for coherence with the other KCompletion classes.


Diffs
-----

  src/kcompletionbox.h 8ed2b00 
  src/kcompletionbox.cpp 571b02f 
  src/kcompletionmatches.h 481a4b9 
  src/kcompletionmatches.cpp bc381b1 

Diff: https://git.reviewboard.kde.org/r/116062/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140226/8bdd0e4d/attachment.html>


More information about the Kde-frameworks-devel mailing list