Review Request 116079: Be more explicit with QFile include

Michael Palimaka kensington at gentoo.org
Wed Feb 26 16:36:02 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116079/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 4:36 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
-------

global.h is a public header, so not being more explicit with includes could cause a build failure for consumers. This should probably go into kdelibs too.


Diffs
-----

  src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159 

Diff: https://git.reviewboard.kde.org/r/116079/diff/


Testing
-------

Builds.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140226/13ba1c5c/attachment.html>


More information about the Kde-frameworks-devel mailing list