Review Request 116062: Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116062/#review50953
-----------------------------------------------------------

Ship it!


Ship It!

- Aurélien Gâteau


On Feb. 25, 2014, 11:35 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116062/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 11:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches for coherence with the other KCompletion classes.
> 
> 
> Diffs
> -----
> 
>   src/kcompletionbox.h 8ed2b00 
>   src/kcompletionbox.cpp 571b02f 
>   src/kcompletionmatches.h 481a4b9 
>   src/kcompletionmatches.cpp bc381b1 
> 
> Diff: https://git.reviewboard.kde.org/r/116062/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140226/cc1e2b16/attachment-0001.html>