Review Request 116018: Add a FindWayland module

[Alex Merry]

> On Feb. 25, 2014, 12:54 p.m., Alex Merry wrote:
> > find-modules/FindWayland.cmake, line 192
> > <https://git.reviewboard.kde.org/r/116018/diff/4/?file=246029#file246029line192>
> >
> >     You know this is going be printed as something like
> >     
> >     "Wayland, Wayland compositor infrastructure"
> >     
> >     by feature_summary?  I would maybe go for "Support libraries for Wayland, a display server protocol designed to replace X11", or something like that.
> 
> Martin Gräßlin wrote:
>     suggestion: "C library implementation of the Wayland protocol; a protocol for a compositor to talk to its clients"
>     
>     that's based on the first sentence of the abstract of the Wayland documentation: "Wayland is a protocol for a compositor to talk to its clients as well as a C library implementation of that protocol."
>     
>     Previous one was the description of the Debian package.

Sounds good to me.  But use a colon (:) instead of a semicolon.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116018/#review50815
-----------------------------------------------------------


On Feb. 25, 2014, 12:46 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116018/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 12:46 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a FindWayland module
> 
> Inspired by the FindXCB module it's using components to simplify
> finding just the parts which are really required.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindWayland.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116018/diff/
> 
> 
> Testing
> -------
> 
> Changed kde-workspace to use this component based variant.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140225/2edf45b0/attachment.html>