Review Request 116018: Add a FindWayland module
Alex Merry
kde at randomguy3.me.uk
Tue Feb 25 12:54:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116018/#review50815
-----------------------------------------------------------
Ship it!
Just put a better description, and then ship it.
find-modules/FindWayland.cmake
<https://git.reviewboard.kde.org/r/116018/#comment35681>
You know this is going be printed as something like
"Wayland, Wayland compositor infrastructure"
by feature_summary? I would maybe go for "Support libraries for Wayland, a display server protocol designed to replace X11", or something like that.
- Alex Merry
On Feb. 25, 2014, 12:46 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116018/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 12:46 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Add a FindWayland module
>
> Inspired by the FindXCB module it's using components to simplify
> finding just the parts which are really required.
>
>
> Diffs
> -----
>
> find-modules/FindWayland.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/116018/diff/
>
>
> Testing
> -------
>
> Changed kde-workspace to use this component based variant.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140225/1c88eb6f/attachment.html>
More information about the Kde-frameworks-devel
mailing list