Review Request 116026: Remove the WebP format

David Faure faure at kde.org
Tue Feb 25 12:08:16 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116026/#review50806
-----------------------------------------------------------

Ship it!


Just add the mimetype to kcoreaddons/src/mimetypes/kde5.xml with a comment about "will be in smi version NNN, remove when we can depend on it"

- David Faure


On Feb. 24, 2014, 5:10 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116026/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Remove the WebP format
> 
> This will be in Qt 5.3.
> 
> The desktop file should go into kde4support.  What about the XML file?  I've got rid of it here, but we could keep it.  Bear in mind that it will be in the next release of shared-mime-info.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 3e30e600216fabf233f5f93b0b64cc368c47b6d5 
>   autotests/read/webp/bw-cwebp-lossless.png e2d506bb3da276c09b8f9388dc8ad6b96f987f5e 
>   autotests/read/webp/bw-cwebp-lossless.webp 3567af16a140d9af685229cb754014476d4bbc35 
>   autotests/read/webp/bw-cwebp.png ea9dcea82f70750467390f6b26624bd4746013f9 
>   autotests/read/webp/bw-cwebp.webp 9c2e0c0a96eb64c035a8689a93c8a651075152a6 
>   autotests/read/webp/rgb-cwebp-lossless.png 267d67841ad5f80e0f36cbf514c33d6e9cac146b 
>   autotests/read/webp/rgb-cwebp-lossless.webp 0151334e7db32d96aae733095aea3aeefa262629 
>   autotests/read/webp/rgb-cwebp.png 528df3fd8e1271cbbcc58618820ad58903a17681 
>   autotests/read/webp/rgb-cwebp.webp d889a9b5e874e319449e7bc2fb4367fbdcdd830e 
>   src/imageformats/CMakeLists.txt 07ce79e82440fef120dad835ba45386481a73594 
>   src/imageformats/webp.cpp c92b7bbd093bccb7e6eb6c34dc23dae4c1cd0436 
>   src/imageformats/webp.desktop 3526be5f1f01907b18c3bd80cf5fb3f0b29a24c4 
>   src/imageformats/webp.h 91e724e3877e9f7ec6acb8c36f0f06f86cc3bac1 
>   src/imageformats/webp.json 9e81ff966ded7b3c415217aef998bf25d9becc55 
>   src/imageformats/webp.xml 68ddbbf334031ea8d023b16a4904f07b8cc8d0ba 
> 
> Diff: https://git.reviewboard.kde.org/r/116026/diff/
> 
> 
> Testing
> -------
> 
> Compiles, installs, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140225/e9456781/attachment.html>


More information about the Kde-frameworks-devel mailing list