Review Request 116018: Add a FindWayland module

Alex Merry kde at randomguy3.me.uk
Tue Feb 25 11:29:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116018/#review50798
-----------------------------------------------------------



find-modules/FindWayland.cmake
<https://git.reviewboard.kde.org/r/116018/#comment35677>

    requiredComponents is appended to but never read from.



find-modules/FindWayland.cmake
<https://git.reviewboard.kde.org/r/116018/#comment35676>

    requiredComponents is appended to but never read from.
    
    This is all dealt with by find_package_handle_standard_args (the last call, with HANDLE_COMPONENTS) anyway.


- Alex Merry


On Feb. 25, 2014, 7:46 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116018/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 7:46 a.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a FindWayland module
> 
> Inspired by the FindXCB module it's using components to simplify
> finding just the parts which are really required.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindWayland.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116018/diff/
> 
> 
> Testing
> -------
> 
> Changed kde-workspace to use this component based variant.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140225/9b137591/attachment.html>


More information about the Kde-frameworks-devel mailing list