Review Request 116018: Add a FindWayland module

[Alex Merry]

> On Feb. 24, 2014, 2:55 p.m., Alex Merry wrote:
> > Same comments as for FindEGL.cmake:
> > - what projects are using it?  I guess KWin is one; any others?
> > - it needs to set the DESCRIPTION and URL package properties (from FeatureSummary)
> > - I've been aiming to create imported targets in new find modules, because they're easier to use (see FindSharedMimeInfo.cmake for an example, or the modules in kimageformats for better examples).
> 
> Martin Gräßlin wrote:
>     and I can kind of give the same answer. Currently KWin is using it (we have a bad find module in kde-workspace) and for KInfoCenter I created a review request today which adds a dependency. I expect that in future almost every framework which has a FindXCB or FindX11 will also get a FindWayland.

Yeah, I think I'd be happy to have FindWayland.cmake in even with only one current user, on that basis.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116018/#review50706
-----------------------------------------------------------


On Feb. 24, 2014, 1:52 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116018/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 1:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a FindWayland module
> 
> Inspired by the FindXCB module it's using components to simplify
> finding just the parts which are really required.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindWayland.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116018/diff/
> 
> 
> Testing
> -------
> 
> Changed kde-workspace to use this component based variant.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140224/a920ef2b/attachment.html>