Review Request 116018: Add a FindWayland module
Alex Merry
kde at randomguy3.me.uk
Mon Feb 24 14:55:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116018/#review50706
-----------------------------------------------------------
Same comments as for FindEGL.cmake:
- what projects are using it? I guess KWin is one; any others?
- it needs to set the DESCRIPTION and URL package properties (from FeatureSummary)
- I've been aiming to create imported targets in new find modules, because they're easier to use (see FindSharedMimeInfo.cmake for an example, or the modules in kimageformats for better examples).
- Alex Merry
On Feb. 24, 2014, 1:52 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116018/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 1:52 p.m.)
>
>
> Review request for KDE Frameworks and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Add a FindWayland module
>
> Inspired by the FindXCB module it's using components to simplify
> finding just the parts which are really required.
>
>
> Diffs
> -----
>
> find-modules/FindWayland.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/116018/diff/
>
>
> Testing
> -------
>
> Changed kde-workspace to use this component based variant.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140224/f2036b28/attachment.html>
More information about the Kde-frameworks-devel
mailing list