Review Request 116014: Add a FindEgl module
Alex Merry
kde at randomguy3.me.uk
Mon Feb 24 14:51:49 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116014/#review50705
-----------------------------------------------------------
Three things:
- what projects are using it? I guess KWin is one; any others?
- it needs to set the DESCRIPTION and URL package properties (from FeatureSummary)
- I've been aiming to create imported targets in new find modules, because they're easier to use (see FindSharedMimeInfo.cmake for an example, or the modules in kimageformats for better examples).
- Alex Merry
On Feb. 24, 2014, 1:08 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116014/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 1:08 p.m.)
>
>
> Review request for KDE Frameworks and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Add a FindEgl module
>
> This module finds the egl library through pkg-config.
>
>
> Diffs
> -----
>
> find-modules/FindEgl.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/116014/diff/
>
>
> Testing
> -------
>
> Adjusted KWin to find egl through this cmake module. Picks up egl, compiles and links.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140224/f9ed226c/attachment.html>
More information about the Kde-frameworks-devel
mailing list