Porting feedback: Hiding the Help button in KConfigDialog

David Faure faure at kde.org
Mon Feb 24 08:38:08 UTC 2014


On Sunday 23 February 2014 20:12:05 Kevin Krammer wrote:
> On Sunday, 2014-02-23, 18:41:38, David Faure wrote:
> > On Sunday 23 February 2014 14:17:29 Kevin Krammer wrote:
> > > But usage of the button box already leaks, there are two protected
> > > accessors  to it.
> > 
> > In which class? You lost me.
> 
> KPageDialog, base class of KConfigDialog according to the API docs
> http://api.kde.org/frameworks-api/frameworks5-apidocs/kwidgetsaddons/html/cl
> assKPageDialog.html

Ah! I only looked at KPageDialog and KDialog and got confused.

OK, then how about we just make that public? Eike, I assume you were not in a 
subclass of KConfigDialog but in code that uses it "from the outside"?

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list