kguiaddons uses qpa headers?

[Kevin Ottens]

On Sunday 23 February 2014 17:47:48 David Faure wrote:
> On Sunday 23 February 2014 17:02:55 John Layt wrote:
> > Hi,
> > 
> > I'm building all of Frameworks from scratch for the first time, using the
> > openSUSE packages for Qt 5.2, and qguiaddons fails with:
> > 
> > [ 24%] Building CXX object
> > src/CMakeFiles/KF5GuiAddons.dir/util/kmodifierkeyinfoprovider_x11.cpp.o
> > /media/build/kdesrc-
> > build/src/k5/frameworks/kguiaddons/src/util/kmodifierkeyinfoprovider_x11.c
> > pp> 
> > :26:42: fatal error: qpa/qplatformnativeinterface.h: No such file or
> > 
> > directory
> > 
> > This is because qpa headers are considered private and are packaged
> > separately by openSUSE.  I'm not sure depending on private/qpa headers is
> > such a good thing?  Or is there no other option here?
> 
> For kguiaddons there's an alternative, linking to QX11Extras (breaking the
> rules about the dependencies for an "addon").
> 
> This is starting to make me wonder if we couldn't change Qt to set a
> property on qApp with the values of Display* and/or xcb connection. But
> personally I would just link to QX11Extras.

Still you were the one with the very strict view on the *addons ones. :-)

Let's go for QX11Extras, but it has to be an optional dependency.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140224/3b4d204c/attachment.sig>