Review Request 115984: Implement the d-pointer in KCompletionBase as in the other classes
David Gil Oliva
davidgiloliva at gmail.com
Mon Feb 24 00:06:44 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115984/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kcompletion
Description
-------
Implement the d-pointer in KCompletionBase as in the other classes
Add two methods: setEmitSignals(bool) and setKeybindingsMap(KeyBindingMap)
to be called from setDelegate(). Otherwise, it doesn't seem plausible
to reach the private member variables like this (the compiler complains):
delegate->d->emitsRotationSignals = d->emitsRotationSignals;
Now that has become:
delegate->setEmitSignals(d->emitsRotationSignals);
For coherence, implement the QScopedPointer and the init() method.
Diffs
-----
src/kcompletionbase.h 105a6d0
src/kcompletionbase.cpp 66f9398
Diff: https://git.reviewboard.kde.org/r/115984/diff/
Testing
-------
It builds. Tests pass.
Thanks,
David Gil Oliva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140224/54284443/attachment.html>
More information about the Kde-frameworks-devel
mailing list