Review Request 115485: Porting KTranscript from KJS to QtScript

[Hrvoje Senjan]

> On Feb. 22, 2014, 3:24 p.m., Michael Palimaka wrote:
> > If this is tier 1 now, please don't forget to update the wiki and the yaml file.

Also find_dependency(KF5JS "@KF5_VERSION@") can go away =)


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115485/#review50535
-----------------------------------------------------------


On Feb. 22, 2014, 2:15 p.m., Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115485/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a tier1 framework.
> Needs more testing and likely fixing
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt c4d6b9b 
>   src/CMakeLists.txt 9e3ce9f 
>   src/ktranscript.cpp b9e0551 
>   CMakeLists.txt 06fb696 
> 
> Diff: https://git.reviewboard.kde.org/r/115485/diff/
> 
> 
> Testing
> -------
> 
> Unittest runs, but the test script is very minimal and would need to be extendedb by someone who understands the scripting requirements.
> There is also a weird crash at test shutdown, in QThreadStorage. As far as I can tell I did not change anything related to threads though.
> 
> 
> Thanks,
> 
> Kevin Krammer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140223/886ae737/attachment.html>