Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

David Faure faure at kde.org
Sun Feb 23 09:56:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115959/
-----------------------------------------------------------

(Updated Feb. 23, 2014, 9:56 a.m.)


Review request for KDE Frameworks and Albert Astals Cid.


Repository: kconfigwidgets


Description
-------

Resurrect KConfigDialog::setHelp (used to come from KDialog).

It controls the default behavior of showHelp(), which is implemented
using KHelpClient.

Move KHelpClient down from kxmlgui, for use in KConfigDialog.


Diffs
-----

  src/CMakeLists.txt 7da7fba0c15153d6dee381c2b8f282e9837eae36 
  src/kconfigdialog.h b06efc588c772ed655d581a0e021d92af5e0e280 
  src/kconfigdialog.cpp 8db48e23f614530cef11a23a182b50d905327405 
  src/khelpclient.h PRE-CREATION 
  src/khelpclient.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115959/diff/


Testing
-------

Compiled all of KF5.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140223/b58a9a4c/attachment.html>


More information about the Kde-frameworks-devel mailing list