Review Request 115028: Inline deprecated KUser::fullName() method

David Faure faure at kde.org
Sat Feb 22 18:46:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review50554
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Feb. 22, 2014, 5:28 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 5:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Inline deprecated KUser::fullName() method
> 
> 
> Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
> 
> KCOREADDONS_NO_DEPRECATED is the macro controlled by
> generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.
> 
> 
> Diffs
> -----
> 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> -------
> 
> configures, compiles, tests pass (well, except KDirWatch-FAM, which has never passed for me).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140222/2bb68123/attachment.html>


More information about the Kde-frameworks-devel mailing list