Review Request 115876: More generic DocBookXML -> DocBookXML4

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115876/
-----------------------------------------------------------

(Updated Feb. 22, 2014, 6:20 p.m.)


Status
------

This change has been discarded.


Review request for Build System, Documentation and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

FindDocBookXML.cmake was originally part of kdelibs/kdoctools, but not installed. The version currently in ECM is, as the old one, is quite tight to the old behavior, it hardcodes the DocBookXML version currently used.
- the rename reflect the fact that it's used for DocBookXML4; a future DocBookXML5 could be added if needed;
- the structure allows a generic usage ("find DocBookXML version 4.x"), not tied to the usage in KDocTools. KDocTools will be changed to call it with the correct version (the version number is a "property" of KDocTools, not used outside it, but hidden inside meinproc5 and libKF5XsltKde.a).
Next changes: 
- use DocBookXML4 (so DocBookXML4_* instead of DOCBOOKXML_* legacy variables) in frameworks
- move the definition of legacy DOCBOOKXML_* in kde4support


Diffs
-----

  find-modules/FindDocBookXML.cmake b6d623e 
  find-modules/FindDocBookXML4.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115876/diff/


Testing
-------

Compiles (some changes are needed in KDocTools, I will add them to another review).


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140222/903926e9/attachment-0001.html>