Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review50501
-----------------------------------------------------------



src/lib/kaboutdata.cpp
<https://git.reviewboard.kde.org/r/115207/#comment35532>

    A unittest would have shown you the bug in this line...
    (you're modifying a copy -> no effect).
    
    Use setProperty, just like the existing line for applicationIconName does.
    
    And then I would remove the inherits() call. It will become a dynamic property if the app isn't a QGuiApplication, no big deal.
    


- David Faure


On Feb. 21, 2014, 2:03 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 2:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Let the KAboutData set information to QApplication. This way we don't have to duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.h 2222c9e 
>   src/lib/kaboutdata.cpp c347521 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140222/7a578e10/attachment-0001.html>